[feat] add header and sidebar css and types #11

devmanta · 2024-11-16T09:38:51Z

📌 Related Issue

#5

📝 Description

사이드바, 헤더 구조 수정 및 일부 css 추가

📸 Screenshot

devmanta · 2024-11-16T09:39:38Z

src/app/(with-header-sidebar)/mydashboard/hooks/useApi.ts

얘는 아직 가져다 쓰는곳은 없는데 나중에 쓰려고? 추가만 해놨습니다

devmanta · 2024-11-16T09:40:14Z

src/app/(with-header-sidebar)/mydashboard/types/user.ts

흠.. user 쪽은 여기저기서 쓰는데 공통 타입으로 빼서 가져다 써도 좋을것같아요
일단은.. 요롷게 두고 추후 합치는 작업 필요할것같습니다

devmanta · 2024-11-16T09:41:23Z

src/components/Button.tsx

 export default function Button({
  className = '',
  children,
+  type = 'button',


공통으로 쓰는거에 button type default값 추가해놨는데 다른 의견있으시면 말씀부탁드립니다~
일반적으로 default는 submit인데 button이 사용빈도가 훨씬 높아서 button으로 default 넣었습니다

devmanta · 2024-11-16T09:42:24Z

src/components/SideBar.tsx

  return (
-    <div>
+    <div className={styles.sideBar}>
+      <Button aria-label="홈페이지 이동" className={styles.button}>


여기서 버튼 classname을 넘겨줬는데 button컴포넌트 css가 나중에 그려지더라고요..?
그래서 !important 사용했습니다 일단은..?
혹시 방법아시는분....?

import styles from './SideBar.module.css';
선언을 가장 아래쪽에 선언하는 것을 생활화합시다 🤣

devmanta · 2024-11-16T09:42:56Z

src/constants/urls.ts

@@ -1,4 +1,4 @@
-const BASE_URL = 'https://sp-taskify-api.vercel.app/10-1';
+export const BASE_URL = 'https://sp-taskify-api.vercel.app/10-1';


요거 axiosInstance에서 가져다 쓰려구 export 추가했어요..!

najitwo

전반적으로 코드가 깔끔하고 재사용성이 높아 보입니다.💯
자그만하게 개선점 제안드렸으니 확인 부탁드립니다.!

najitwo · 2024-11-16T10:37:16Z

src/app/(with-header-sidebar)/mydashboard/hooks/useApi.ts

+  const [error, setError] = useState<AxiosError | null>(null);
+
+  const fetchData = useCallback(async () => {
+    setLoading(true);


Suggested change

setLoading(true);

if (loading) return;

setLoading(true);

이미 로딩 중인 경우 중복 호출 방지하기 위해 이런 처리가 있으면 좋을 것 같습니다.

@najitwo 왜인지?모르겠는데 gpt 한테 리펙토링 해달라고하면 쟤를 없애더라구요...?
useAPi custom hook 찾아봐도 loading 중이면 return하는 코드는 없어서 먼가 이유가 있지 않을까 싶긴한데
요거 TODO 주석으로 해놓고 고려사항으로 넣어두겠습니다! 👍

najitwo · 2024-11-16T10:40:05Z

src/app/(with-header-sidebar)/mydashboard/hooks/useWindowSize.ts

+
+interface WindowSize {
+  width: number;
+  height: number;


resize할때 height 값도 필요한가요? 🤔

@najitwo css media 너비 관점에서는 필요없긴합니다 ㅋㅋ
근데 이름이? useWindowSize니까 높이도 껴서...?

najitwo · 2024-11-16T10:45:57Z

src/app/(with-header-sidebar)/mydashboard/utils/axiosInstance.ts

+export const apiCall = async <T>(
+  config: AxiosRequestConfig
+): Promise<AxiosResponse<T>> => {
+  return axiosInstance.request<T>(config);


여기에 에러 처리 로직이 있으면 좋을 것 같습니다!

이친구는 아직 미완성...이긴해서
에러처리 고려하겠습니다~! 🙇🏻‍♀️ (아님 없앨수도...?)

✨ feat: add header and sidebar css and types

6cf6c4b

devmanta commented Nov 16, 2024

View reviewed changes

devmanta self-assigned this Nov 16, 2024

devmanta added 🎨HTML&CSS Issues or tasks specifically related to HTML structure or CSS styling 📬API Tasks related to integrating or connecting to external APIs labels Nov 16, 2024

devmanta requested review from a user, najitwo and naseungyeop November 16, 2024 09:44

najitwo approved these changes Nov 16, 2024

View reviewed changes

devmanta merged commit 628f69d into develop Nov 16, 2024

najitwo pushed a commit that referenced this pull request Nov 18, 2024

✨ feat: add header and sidebar css and types (#11)

c4146a4

najitwo pushed a commit that referenced this pull request Nov 23, 2024

✨ feat: add header and sidebar css and types (#11)

68cc1ee

		@@ -1,4 +1,4 @@
		const BASE_URL = 'https://sp-taskify-api.vercel.app/10-1';
		export const BASE_URL = 'https://sp-taskify-api.vercel.app/10-1';

[feat] add header and sidebar css and types #11

[feat] add header and sidebar css and types #11

Uh oh!

Conversation

devmanta commented Nov 16, 2024

📌 Related Issue

📝 Description

📸 Screenshot

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devmanta Nov 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

najitwo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

devmanta Nov 16, 2024 •

edited

Loading